hydai

Results 815 comments of hydai

Personally, I prefer `cargo-dist`. The only reason is that this tool is used and verified in more projects than `knope`. I expected that we should not take too much time...

Then, let's do `knope`. I would also like to see if this new tool can help.

Hi @alan910127, I would like to change the way we test WasmEdgeUp. Let's say there is a dummy JSON file shipped with WasmEdgeUp (maybe inside the test folder). You can...

Yup, you can find the example JSON file from the spec of this project. Originally, we would like to fetch the JSON from the official repository, however, it seems that...

> I’d argue that conditional compilation attributes (`cfg`s) should be sufficient. The answer is yes we do need it. We encountered this case before due to the environment is very...

> I'm curious—do you remember the specific case? I feel like something like `args.os.unwrap(compile_target_os())` should handle this correctly, though. I don't remember the details. It happens on CentOS7 due to...

Hi @alan910127 I found that knope-bot uses an invalid commit message format to raise the PR: https://github.com/WasmEdge/wasmedgeup/pull/29

> @hydai For now, they don't support customization for the commit message used by knope-bot yet. Maybe we could ignore the commit made by knope-bot in commitlint as a workaround....

Never mind, let's bypass the commitlint for now as a workaround. Would you like to trigger the release process again?