Hao-Wei Pang

@mjohnson541 I think `p=p` is necessary because otherwise the default `SciMLBase.NullParameters()` is getting passed in, rather than the actual `p`. Why did we make this optional in the first place?...

@mjohnson541 pointed out that this will likely break RMG's CI. Could you point out where in RMG CI do we need to change to avoid breaking it? cc @JacksonBurns

@mjohnson541 Recording our offline discussion here: We should replace pyjulia with JuliaCall in RMG (see here: https://juliapy.github.io/PythonCall.jl/stable/pycall/). It should make the installation process easier. cc @JacksonBurns

RMS-RMG twin PR: https://github.com/ReactionMechanismGenerator/RMG-Py/pull/2640

@mjohnson541 Can you make the pyrms PR since you've looked into this? Thanks

@mjohnson541 I addressed your comment and had a question. I will write pretty commit messages after we agree on the changes

Removing the duplicate export would cause the test to fail. I undo the change.

@mjohnson541 This is ready for another review / approve. Need to clean up the commits after approval and coordinate to merge at the same time with https://github.com/ReactionMechanismGenerator/RMG-Py/pull/2640.

Thanks for the PR! I see that the test is failing with ``` Test vapor-liquid phase multi-domain reactor simulation with VaporLiquidMassTransferInternalInterfaceConstantT and VolumeMaintainingOutlet interface: Test Failed at /home/runner/work/ReactionMechanismSimulator.jl/ReactionMechanismSimulator.jl/src/TestReactors.jl:143 Expression: ≈((sol(sol.t[end]))[ind],...

Thanks for catching this. I will work on this after I submitted my manuscript revision. I'm somewhat more occupied right now.