Hao-Wei Pang
Hao-Wei Pang
> This is fine but the changes order doesn't make much sense. Can you split the creation of the has_wildcards function into one commit and the naming/calling changes in to...
> Can you rebase? Rebased!
@mjohnson541 Rebased!
Rebased again!
I thought I have fixed this bug in #1918 but I guess this bug is still there. I will take a look at this.
@ysadat7 Hello! I was able to run your script with the temperature range on the current master without encountering any errors. Are you running on the newest commit on the...
A bit of context on why we needed to release the new version of pyrms right before RMG Training: the new version of pyrms was required for the threaded sensitivity...
> I think the differences in the core regressions for liquid runs look alright, the observable failure for RMS_CSTR_liquid_oxidation gave me a bit of a pause, but it looks like...
> > > I think the differences in the core regressions for liquid runs look alright, the observable failure for RMS_CSTR_liquid_oxidation gave me a bit of a pause, but it...
@kspieks Thanks for the review! The unit test is just added!