hwangsihu

Results 69 comments of hwangsihu

Don't bother the developers. They'll merge or close it someday.

Yeah, as you said, it seems like there's no problem. I think we can merge them for now. If there's a problem, we can just revert them later, right?

Rather, I'd like to ask: Why did you change it like that? You didn't seem to explain the reason, so if I missed it, I apologize.

I don't have full access either. I can only merge changes the way I want if the code owner approves them. And most importantly, I don't want to arbitrarily merge...

First of all, I apologize if my words came across as rude. But I wasn't ignoring you. I was just wondering why the logic changed, but I understand.

I'm not sure if updating WebRTC will fix this issue. @bear101, could you please update WebRTC?

HM, I want to test my iTeamTalk source, but got an error. ``` /Users/***/TeamTalk5/Client/iTeamTalk/iTeamTalk.xcodeproj The iOS deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 9.0, but the range of supported deployment target...

This issue has been resolved in the PR above. Please try again after merging the webrtc branch.

Limiting it to 8 characters doesn't seem like a good idea.