Hussain Thajutheen

Results 68 comments of Hussain Thajutheen
trafficstars

Thanks, @wpdarren. I have fixed observation `#2` in this follow-up [PR](https://github.com/google/site-kit-wp/pull/5866). As for the first one, I think it could be part of #5837. cc: @techanvil

Thanks, @eugene-manuilov, @aaemnnosttv, and @techanvil. I have updated the IB accordingly. I have increased the estimate by considering adding tests. I have added a point for calling the `trackEvent` when...

Thanks for pointing it out, @eugene-manuilov. I have updated the IB as per the change request.

@nfmohit, when double-checking the [Figma design and the comments](https://www.figma.com/file/vMaCWwr6lpk4PrJWb7jIpz/GA4-Banner-Input?node-id=1285%3A2032) related to it, it seems we should not open the accordion. The gray CTA button indicates it's disabled. However, there are...

Thanks, @techanvil. That brings another question, what do we do with the `Setup incomplete: [continue module setup](http://sitekit.10uplabs.com/wp-admin/admin.php?page=googlesitekit-dashboard&slug=adsense&reAuth=true)` link?

@wpdarren the steps mentioned in the QAB are correct. I was able to reproduce it. This is the screenshot from my secondary admin dashboard: ![Screenshot 2022-08-23 at 10 23 40...

Thanks for calling out @FlicHollis. I have unassigned myself.

@mohitwp @wpdarren, thanks for bringing this up. The PR removes the legacy code. So, there is nothing specific to be tested. However, I have updated the QAB. LMK if that...

@eugene-manuilov, could you check it on your local? I don't think PropTypes warnings are visible on the hosted one.

@eugene-manuilov, please run the storybook on your local http://localhost:9001/?path=/story/global--image-radios