Jiachi Liu

Results 212 comments of Jiachi Liu

Edge runtime doesn't support DOM api like `document`, and the browser bundle of `@emotion/cache` removes those checks like `typeof document !== undefined` that assuming browser bundle will always have DOM...

Removing the browser field also sounds a way to go, I think bundler can still optimize those conditions when emits client bundle, and do proper tree shake to keep the...

@diego-paired can you share a minimal repo or any oneline reproduction of that issue that we can debug and investigate?

Can we add some description for this PR like: * what the e2e suite does? * what kind of the cases are covered? * why we need to have this?...

Does [config.isPaused()](https://swr.vercel.app/docs/options) work for your cases? ```js useSWR(key, fetcher, { isPaused() { return /* condition for dropped requests */ } }) ```

Looks like the custom cache has been recreated so that swr cannot access the original one. A workaround to get rid of this is keep same provider instance in each...

Yeah sure, we'll update the docs later to present it with a better approach. Thanks!

As https://github.com/vercel/swr/issues/141#issuecomment-792077186 said, composing `data`, `error` and `isValidating` will result in 8 cases that make `status` enums hard to remeber for users. IMO it's better to keep automic for returned...

> Having both is acceptable to avoid a breaking change. Once either of me needs to be removed that gonna be a breaking change 😂 > it's a good practice...

> In the most of big tech companies, they have enabled eslint rule - [import/no-default-export](https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-default-export.md) I don't feel like because of the existence of this eslint rule so that we...