Hans
Hans
I'm a bit confused about the way we get selected card to issue here: https://github.com/Expensify/App/blob/bef062b4caa7f665159dc107911e708031e648c4/src/pages/settings/Wallet/Card/BaseGetPhysicalCard.tsx#L113-L114 Once the successful data arrives, `cardToBeIssued` will become undefined because its state is now `NOT_ACTIVATED`...
> > Once the successful data arrives, cardToBeIssued will become undefined because its state is now NOT_ACTIVATED (4). > > Yeah, I think that's expected, though - the card is...
@NikkiWines Can you check again? I updated the new condition to navigate user to the next route when API was called successfully.
> @hungvu193 is there anything you need to move forward here? Is this ready for review by @dominictb? (thanks for stepping in @dominictb!) It's ready for review
> Also, is it possible to update this screen to match our other magic code screens? The Verify button should be at the bottom like our normal "footer buttons" and...
> @hungvu193 Are [#51135 (comment)](https://github.com/Expensify/App/pull/51135#issuecomment-2424826532) and [#51135 (comment)](https://github.com/Expensify/App/pull/51135#issuecomment-2451425006) expected? Or are we waiting for BE changes? I think they're expected for now. I believe we don't want to block existing...
> Couple of comments Addressed all the comments
@Kalydosos What's the best way to reproduce this one?
I've been a bit under the water today, but def can give a decision this week.