Hans

Results 203 comments of Hans

Little bump on the comment above @Tony-MK

Thanks for your update. I'll check it today!

I think it failed the first testcase, please check the video below: https://github.com/user-attachments/assets/62a0efd0-cf2d-4366-ba1c-2180ab65530f

If you see in the video, the search query in the first tab is different with other tabs

The problem here is the inconsistency when switching between the filter tab

Please update the screenshots/video based on your new changes and make sure the original issue + the issue I commented above don't appear. Test it carefully before requesting a re-review....

@Tony-MK I think we're still facing the same issue. Please look at the video below: https://github.com/user-attachments/assets/3ea91f1e-c60e-4d4a-8d12-d4a48bf7e55d I'm still seeing extra `"` was added into our string.

I think in the above video that you posted when you enter `"https://facebook.com"` and press `Save Search`, the filter text returned `""https://facebook.com""`which had extra doule quote mark.

> Therefore, `"http://facebook.com"` returns `""http://facebook.com""`. Hmm, I'm afraid I have to disagree with you at this point, if our keyword's already wrapped inside `"`, I think we shouldn't add `"`.

Thanks for your update. I'll take a look today!