hungvietnguyen

Results 7 comments of hungvietnguyen

> @hungvietnguyen Can you please trigger an `arr` run for this PR? As discussed offline, @Tapchicoma will help with this. Thanks!

I've tried the following patch in Gradle, and it seems to fix the issue: #### Proposed patch ``` // In DefaultConfiguration.java private static class ConfigurationArtifactCollection implements ArtifactCollectionInternal { - ResolvedArtifactCollectingVisitor...

That sounds great, looking forward to this issue being fixed! Btw, the core of this issue and related issues in this area seems to be the **lack of a clear...

Adding an example relating to this issue: We're having a cacheability issue in the Android Gradle plugin (https://issuetracker.google.com/266403349) due to our use of `FileTree` as inputs at [MergeGeneratedProguardFilesCreationAction](https://android.googlesource.com/platform/tools/base/+/8fa673599fe336e3d1d6cc7d585730ecfb45aabd/build-system/gradle-core/src/main/java/com/android/build/gradle/internal/tasks/MergeGeneratedProguardFilesCreationAction.kt#78). This task...

> What reason is there (besides maybe performance?) to use a non-reproducible file order when visiting a file tree? I think none. Having reproducible file order is always nice, especially...

Another small note: `FileTree` may have multiple roots. When sorting `FileTree.files`, it's important that we sort files within the same root only, not across roots, because the order of the...

Side note: Here are the PRs mentioned in the previous comment: https://github.com/gradle/gradle/pull/18788, https://github.com/gradle/gradle/pull/22048 ("Add the variant identity to the seenArtifacts key").