typomagical-obsidian icon indicating copy to clipboard operation
typomagical-obsidian copied to clipboard

Network usage is prohibited for themes

Open joethei opened this issue 2 years ago • 5 comments

It appears that your theme uses network connections to load assets (e.g. fonts, icons, or images). This is prohibited by the official Obsidian developer policies because themes should function completely locally.

You can bundle an asset for local use by using data URLs. See this guide.

Please let us know if you have any questions. Any themes that use network connections will be removed from the official directory in the first week of January 2024.

  • The Obsidian team.

joethei avatar Nov 20 '23 18:11 joethei

Are there plans to address this, @hungsu? The latest Obsidian update seems to have broken the fonts in this theme by disallowing loading them, and the deadline stated in the issue is approaching.

image

omarkmu avatar Dec 28 '23 01:12 omarkmu

Thanks for the reminder @omarkmu . There's a lot of work here so I'll be chipping away at this in pieces, hopefully all before deadline

hungsu avatar Dec 28 '23 16:12 hungsu

A note to anyone following along: I most likely will be removing some fonts:

  • Amiri
  • Bitter

This is because I never use these, and the theme is already becoming quite large with the fonts I do use at 442KB. If anyone objects to this, feel free to file an issue and I can put them back.

hungsu avatar Dec 28 '23 19:12 hungsu

Hi @joethei , can I confirm that I only need to remove network assets from theme.css, or do I also need to remove them from the legacy obsidian.css also?

hungsu avatar Jan 04 '24 00:01 hungsu

Please do it for both.

joethei avatar Jan 05 '24 10:01 joethei

@joethei All network requests should be removed. Instead of removing network requests from obsidian.css, I have chosen to delete it as I do not believe anyone is using Obsidian older than 1.0.0 at this point. If there are more concerns please re-open this issue

hungsu avatar Feb 26 '24 16:02 hungsu