David Humphrey comments

Results 477 comments of


                                            David Humphrey

Add test for rename() when oldPath and newPath are the same

OK @VictorKubrak, go for it.

Critical dependency: the request of a dependency is an expression

Agree this should be done. Switching to Parcel 2 is something I'd take a PR for, but it's not something I'm likely to do soon due to my schedule.

Critical dependency: the request of a dependency is an expression

@joshuali7536 sounds good. NOTE: the use of parcel is not critical here. Ideally the move to Parcel 2 should be the easiest thing to do (start with that); but if...

Adding support for promises API --- chmod

OK, go for it @Peng-Qu.

Update filer/tests/spec/fs.spec.js to use let/const with strict mode

Sounds good @OnesQuared, go for it.

Add recursive option for fs.mkdir to match node.js

I'm going to work on this with my class. Assigning to myself.

Experimental `next` branch

See discussion in https://github.com/filerjs/filer/issues/566#issuecomment-443933897

WIP: Build and run tests with webpack

Ping me when you want reviews on these.

WIP: Build and run tests with webpack

I think doing it in this repo is probably the best idea, since it has CI setup already, and is so closely related to the other code. I'm more wondering...

Add the test for fsPromises.readdir when the path exists, and is a directory

Great, go for it it @ywpark1.