David Humphrey comments

Results 477 comments of


                                            David Humphrey

Filer project rename

Love WebFS. Had been thinking the same thing since we spoke. I haven't googled it. If it's not taken, let's do it.On Jul 5, 2018 4:38 PM, Alan K wrote:Thinking...

Update and modernize /tests/spec/errors.spec.js to use let, const, and strict mode for best practices.

Go for it @PrimeN.

Add a test for fs.rename() when target file/directory doesn't exist

Great, go for it @itchylol742

Add test for fs.open() with O_WRITE and the root directory as path /

Also add another test for this same case, only first create a symlink to `/` and follow the same procedure as above. This should get us into https://codecov.io/gh/filerjs/filer/src/master/src/filesystem/implementation.js#L636.

Add test for fs.open() with O_WRITE and the root directory as path /

@cdrani no, you can skip the `/tmp` dir and use `/`.

Add test for fs.link() with newpath pointing to an existing file

Also, add another test for the same case using `symlink` instead of `link`, and try to hit https://codecov.io/gh/filerjs/filer/src/master/src/filesystem/implementation.js#L1147.

rename() fails to rename a file to itself

It's all yours @VictorKubrak! Thanks for finding this, and following through with a bug (and a fix). Let me know how you make out as you do your research and...

Implement lchown

@andrewkoung sure, let's discuss in class tomorrow.

Implement lchown

@andrewkoung yes, that is exactly what it does. It basically means: "get the file node for the super-node, and once we have that file node object, pass it to the...

Update filer/tests/spec/fs.unwatchFile.spec.js to use let instead of var

Go for it @QingLianLiu.