Manuel Kaufmann

Results 368 issues of Manuel Kaufmann

We have some commands shown in the output page that are useful _only_ when debugging an issue with the build, but most of the time they are not and just...

Feature
Accepted

We are currently serving `/README.html` and `/README.html` in https://github.com/readthedocs/readthedocs.org/blob/e85ee7dbadfec7735d89427ed7083b38ea22284e/readthedocs/proxito/views/serve.py#L301-L327 This is _not a standard behavior_ and we have it there because of pretty old compatibility reasons. I'd like to deprecate...

Needed: design decision

We use something called "Cold Storage" that removes old builds from our database and store them in a `.json` file in S3: https://github.com/readthedocs/readthedocs.org/blob/03c03fa4de2a52fb5bbbbd8ab047e485abcc310c/readthedocs/builds/tasks.py#L183-L240 We would need to think and discuss...

Needed: design decision

This is similar to what we are doing in PostgreSQL to avoid running long queries and degrading the service. Related https://github.com/readthedocs/addons/issues/84

Remove a bunch of these following lines when modifying a file. ``` proxito_1 | [2024-03-06 15:32:58 +0000] [22] [ERROR] Worker (pid:23) was sent SIGTERM! proxito_1 | [2024-03-06 15:32:58 +0000] [22]...

I found there is an option to remove the initial banner in Celery, but I'm not sure how to pass that argument. See https://github.com/celery/celery/issues/3496 ``` build_1 | Please specify a...

Improvement

The idea would be to call `inv docker.up --addons-local-dev` or similar and make the CF worker to inject `http://localhost:8000/readthedocs-addons.js` instead of the `/_/static/` URL. See https://github.com/readthedocs/readthedocs.org/pull/10965#discussion_r1479728044 for more context.

Improvement

We may want to generalize the implementation I've done in addons and share it with other projects. See https://github.com/readthedocs/addons/pull/116#pullrequestreview-1617933134

In theory, `nodemon` should watch only 779, ``` root@716db483de08:/usr/src/app/checkouts/readthedocs.org# find ./readthedocs -type f -name '*.py' | wc -l 779 ``` but it says it's watching ~5k: ``` web_1 | [nodemon]...

Improvement

We shouldn't require this anymore now that we are running the `git` commands inside the Docker container. This mount could probably removed completely: https://github.com/readthedocs/common/blob/master/dockerfiles/docker-compose.yml#L110 Allows to avoid `VersionLocked` exception when...