Manuel Kaufmann

Results 1301 comments of Manuel Kaufmann

They are in this state because of the bug we had that didn't set `healthcheck` and leave it always as `None`.

Interesting... All of those builds are builds that were tried to be cancelled, and it seems the cancellation failed for some reason (Celery internals, don't surprise me 😄 ) The...

I found there are a few logs saying the `Build` object wasn't able to be updated with `finished` state when hitting the API. This could explain some builds with `healthcheck=None`...

If you check any of the build ids you shared (example, [29775055](https://onenr.io/0nQxGnKYAjV)), you will notice that there is no `Build finished` log line at the end. That means that the...

_Maybe_, the cleanup part of the build is not executed because `set_builder_scale_in_protection` failed **and** the build was terminated by AWS before executing `after_return`. I opened https://github.com/readthedocs/readthedocs.org/pull/12504 to log the `build_id`...

I just checked this again: https://github.com/readthedocs/readthedocs.org/issues/12473#issuecomment-3355935031 ``` # community In [1]: from readthedocs.builds.constants import BUILD_FINAL_STATES In [2]: Build.objects.filter(date__lt=timezone.now() - timezone.timedelta(days=1)).exclude(state__in=BUILD_FINAL_STATES).count() Out[2]: 144 # commercial In [1]: from readthedocs.builds.constants import BUILD_FINAL_STATES...

Now, 160 in community and 21 in commercial. The increase of these builds is pretty low. That's good 👍🏼

I tested this locally and it worked great! It's ready for review by another human 😄

I think the Conda ecosystem is broken 🥲 That said, either path works for me. We can support it as a `build.tools` or we can document what I explain https://github.com/readthedocs/readthedocs.org/issues/11690#issuecomment-2838545476...

> Do we have numbers for how many people were using mamba in builds? That would help make the decision. 640 projects in the last 30 days. You can play...