Manuel Kaufmann

Results 1301 comments of Manuel Kaufmann

I added the validation and update the docs.

@stsewd this is ready to re-review 👍🏼

> Shouldn't this also be allowed when creating a project? It's allowed when creating a project. The serializer `ProjectSerializer` contains this field.

Another important benefit that I'm seeing here about making querying our database easier: while working on the deprecation of config file and `build.image` I had to make multiple queries and...

> I think the biggest issue will be performance on the query, since we have to do a join, but should be fine and similar to our existing approach. This...

Interesting hack 👍🏼 . If we clone a node, all the events attached to that node are not cloned? > By default, cloning a node copies all of its attributes...

This is probably the same case we are tracking in https://github.com/readthedocs/readthedocs.org/issues/12492

I think this is related to Celery based on the logs: https://onenr.io/02wdE4oGzRE We set all the attributes in the DB for this build as cancelled and triggered a `revoke` command...

This is a good starting point to create the field and start populating it. We can move forward here and then work on the part two of this work: use...