Chris Thorn

Results 9 comments of Chris Thorn

Bikeshedding aside for now, the lowest common denominator means: - JSON encoded for easy interop - support for method names (as they were registered with `.HandleFunc()`; reflecting the names of...

I'll take the first whack at a concrete protocol: ``` javascript { "square": { "signatures": [ [ { "name": "num", "type": "float64" }, { "name": "callback", "type": "function", "signatures": [...

Some feedback: 1. we should use JSON, not YAML. 2. Your proposal does not support "kwargs", which are needed. 3. We need to support callbacks for now, even if there...

Also, there is support for optional arguments in go, just not optional positional arguments. Go supports optional "kwargs" implemented as `map[string]interface{}`. Optional arguments are also supported in other programming languages...

I did it this way, which seems to work? ```javascript import { table } from 'cli-ux/lib/styled/table'; // ... const columns: table.Columns = {}; ```

it seems like it's calculating the dimensions before the image loads. Can you add width and height to the img tag? If that's not possible, perhaps try preloading the image...

please excuse my drive-by comment: does e.g. [`generateBars`](https://github.com/plouc/nivo/blob/31ce26a80120d57955acbf02b0ebe7d59afde5bd/packages/bar/src/hooks.ts#L98) need a memo? (i would look but i was having trouble getting this repo to play nice with volta)

There is one part of the OP that I feel didn't get answered here, and that is, are the dialing codes authoritative? Considering that some dialing codes are not present...

The proposed syntax looks great! `do => {}` is a syntax error, so i don't see a big problem here... it would be just as much of problem for regular...