Michael Khalturin

Results 8 comments of Michael Khalturin

[BUG] Incompatibility with ClickHouse API

Yes. I will fix that.

[QUESTION] Possible unexpected behavior in cacheSize/cacheItems metrics

It looks like unexpected behavior in [`expire := f.expire + f.grace`](https://github.com/ContentSquare/chproxy/blob/master/cache/filesystem_cache.go#L240). As far as I understand, `expire` calculated like this to prevent `thundering herd` and in fact calculated like this...

[Feature] Shared cache grants check option

Sorry for the delay, I got lost in my day job. Yes, I will come back to this PR in a few days.

[Feature] Shared cache grants check option

Sorry again about long response. > What I'd love to see is some tests around the feature you are adding and also if you could fix lint issues. In my...

[Feature] Shared cache grants check option

> no pb, it's the same on our side. Do you still plan to work on this PR @hulk8 ? Sorry for the delay. Now I plan to finish this...

[Feature] Shared cache grants check option

Yes, sorry for the delay

Minor test suite refactoring and adding benchmarks

For uploading benchmark results to GH Pages we need to create branch `gh-pages` in which they will be stored (it's the reason of pipeline fail on uploading benchmark step).

Attempt to cache python environment in lint ci step

At the start, I attempted pip caching, but it didn't provide any advantages and ran slower than just installing all prerequisites. It takes about 1 minute to fetch all cache...