Hugo Dias

Results 92 comments of Hugo Dias

Can't really support import.meta.url since tests are all bundled. But you can just fetch any file in cwd or pass --assets and change it another folder

Humm maybe I can define import.meta.url using the file path from esbuild metadata.

Release no longer has that flag, to achieve that behavior use the config file.

i would like to do something like that with the `aegir check` cmd.. mixing linting with type check seems wrong but maybe im just overthinking here.

We also have a mono-repo setup here https://github.com/ipfs-shipyard/nft.storage with different types of packages that need different kinds of post release tasks using release-please

This should not happen, we have tests for Electron. This is probably a webpack config issue, @raphael10-collab you must be bundling with target browser or renderer but running the code...

i dont have strong feeling regarding typed methods or a buffer like CID.from but i think we should only have one or the other not both. Regarding type checkers im...

> If later that would be pretty wonderful, and step towards #109. On the other hand it may break some assumptions about the availability of certain instance methods. yes this...

Got it, I guess I would like to find a solution that could be applied to all the other modules that use class-is. Something like this https://github.com/feross/is-buffer/blob/master/index.js Even something that...

yeah, sure and we can go a bit further and test for constructor, the isCID method itself and some critical internal data/component that would fail for breaking changes. @mikeal how...