hugleo
hugleo
Maybe can work with this: https://github.com/koreader/android-luajit-launcher/pull/436
It seems like as seeing in the log: ```"Looks like '02-09 07:18:36.395 16369 16402 V NativeThread: Activity window ready.'" ``` is never called in the case of the nitpick problem....
> @hugleo: sorry, I miss this PR. > > I have no problem with these changes. Do you want them merged? > > How I should name it? Something like...
Maybe something messing with the config? What the contents of defaults.custom.lua file?
Could you try like that? ``` STARDICT_DATA_DIR = /mnt/onboard/.adds/dict, ``` EDIT: That will even´t read I'm looking at it...
yes, but not exactly. The problem is here with dofile: https://github.com/koreader/koreader/blob/master/frontend/luadefaults.lua#L46 dofile will not load STARDICT_DATA_DIR even if is explicit defined with nil value. We use this var here: https://github.com/koreader/koreader/blob/master/frontend/apps/reader/modules/readerdictionary.lua#L110...
PS: There are one more item in config that is defined with nil value: NETWORK_PROXY = nil, Will be affected as well.
for reference: https://stackoverflow.com/questions/40441508/how-to-represent-nil-in-a-table or https://forums.solar2d.com/t/inserting-nil-into-table/327955/3 ``` > t = {a = "1", STARDICT_DATA_DIR = nil, b = 2} for key,_ in pairs(t) do print(key) end b a > ```
> > Shouldn't we have seen this 2 or more years ago already? What changed since? > > **Four** since [f756a6a](https://github.com/koreader/koreader/commit/f756a6aaa75b81201fbf302adc9d21cef560c810) 🤔 > > TBH I didn't check advanced settings...
We have EINK_WAVEFORM_UPDATE_FULL = 32 constant, I think add a new constant to NTXEPDController.kt UI_FULL_REFRESH = -2147483644 or EINK_MODE_FULL = -2147483644 And create a new driver called NewNookEPDController.kt and use...