Jaewan Park comments

Results 20 comments of


                                            Jaewan Park

Fix bugs where pooling slices are not reused

This is related to issue #35

For unary methods, received messages are put into buffer from the pool, but buffer is never returned back to pool.

@easwars > @hueypark : Do you see any issues at all with the implementation? I remember that you wanted this functionality quite urgently. Have you been using this buffer pool...

For unary methods, received messages are put into buffer from the pool, but buffer is never returned back to pool.

@efremovmi > you can add your own pool that will permanently hold memory, so it will still work well, unlike sync.Pool. The problem is that now nothing is returned back...

For unary methods, received messages are put into buffer from the pool, but buffer is never returned back to pool.

Sure, I'll take a look and pick it up.

rpc_util: Fix `RecvBufferPool` deactivation issues

This PR will fix https://github.com/grpc/grpc-go/issues/6578.

rpc_util: Reuse memory buffer for receiving message

I implemented a feature stream counts at the benchmarkmain and ran my workloads. The following is the result of the benchmark. ``` unconstrained-networkMode_Local-bufConn_false-keepalive_false-benchTime_10s-trace_false-latency_0s-kbps_0-MTU_0-maxConcurrentCalls_1-reqSize_1048576B-respSize_1048576B-compressor_off-channelz_false-preloader_true-clientReadBufferSize_-1-clientWriteBufferSize_-1-serverReadBufferSize_-1-serverWriteBufferSize_-1- Title Before After Percentage TotalOps 0 0...