Hubert Łępicki

Results 32 comments of Hubert Łępicki

This is a good point. I'm again slightly out of my depths, but I assumed the binaries are *not* copied between processes, but a reference is passed, so as long...

To the good people that find this thread and are wondering what @gaearon tip means: you likely to have the following code in your child component: ``` if (someVariableChanged) {...

I know it's an implementation detail, but I suggest we make it an official behavior instead. The solution to use Plug is okay, but it has to be a macro...

@tsloughter you're actually bringing an interesting point, by chance, as the other Logger statements are being generated as well, based on telemetry events: https://github.com/phoenixframework/phoenix/blob/ad4cd8b224c60a644090242e6a70e2b6404c9c1a/lib/phoenix/logger.ex#L132-L138 Logger is one thing, and if...

@bryannaegele I agree completely. For my use cases, the switch from own instrumenter to telemetry, made by Phoenix and friends, take a step in somewhat the wrong direction for that...

@bryannaegele okay thank you so much. For now your solution seems to work, i.e. I added event handler that feeds the events I am interested in to another events dispatch...

It's funny how I went through the same options when looking at the code. I agree the HandlerConfig is meant to be passed to the handler itself, so it's not...

I have made a proposal in the PR but please do check my erlang style as I'm not used to writing it.

@derekkraan which event (I assume events, not metrics) you want to publish? I was thinking all events related to processes being started, killed, restarted by Supervisor and all the registration...

@josteink @SanketDG @Nishanthi have you guys ever managed to resolved that? I am having the exactly the same issue as described above: the "thread_view" nor "email_view" (nor "delete" etc. for...