http

http copied to clipboard

Requests with body keep connection open for extra 5 seconds

4

Request: ``` > HTTP.post('https://example.com/any', :body => "some") => #"nginx/1.14.2", "Date"=>"Wed, 30 Jan 2019 12:02:30 GMT", "Content-Type"=>"text/html; charset=utf-8", "Content-Length"=>"1564", "Connection"=>"close", "X-Request-Id"=>"6976f707-699c-450b-8f99-fecce91cf9b3", "X-Runtime"=>"0.007562"}> ``` Server log on Nginx: ``` 192.168.241.13 - -...

Vanav

Right now one is forced to manually specify Accept-Encoding header: ``` ruby HTTP.headers(:accept_encoding => "gzip,deflate").use(:auto_inflate) ``` Will be awesome if it will be possible to do simply: ``` ruby HTTP.use(:auto_inflate,...

ixti

Sensitive headers (Authorization and Cookie) are sent to cross-site when redirecting. For example, an original target URL is http://example.com and redirect to http://example.jp (cross-site). The sample code is the following....

kyoshidajp

Connection closes even though it's supposed to be a persistent connection.

6

I have recorded this in wireshark. I am talking to an API (Rails, delivered via NGINX). For some reason, the persistent connection is not persistent: ``` GET /endpoint/updated_at?param1=a HTTP/1.1 Accept:...

ccoenen

Improve logging feature

4

First of all logging works badly on redirects: ``` ruby HTTP.use(:logging => { :logger => logger }).follow.get("http://www.sensortower.com") ``` Prints out: ``` I, [2018-10-24T10:50:00.444268 #20827] INFO -- : > GET http://www.sensortower.com/...

ixti

couldn't read response headers (HTTP::ConnectionError)

12

I get this error when using persistent connection with high `keep_alive_timeout` value. Test script: ```ruby require "http" url = "https://www.google.com/" client = HTTP.persistent(url, timeout: 1000) puts Time.now puts client.get(url).to_s.size sleep...

tycooon

Timeouts when streaming responses on persistent connections can cause HTTP::StateError errors for retries

1

in the general form of ```ruby begin response = connection.request(...) response.flush rescue HTTP::TimeoutError retry end ``` If there is a timeout while reading the body in `#flush` then the state...

mattbooks

Additional breaking changes for 5.x

6

#446 will contain breaking changes. Since we're bumping major versions against at a `x.0.0` release, perhaps it's worth considering if there are any additional breaking changes we want to make...

tarcieri

Caching spport

5

Existing implementation has couple of issues: - dependency on rack-cache - restored response loses `uri`

ixti

Refactor Options

3

Right now HTTP::Options looks really terrible.

ixti