http
http copied to clipboard
httprb
Additional breaking changes for 5.x
#446 will contain breaking changes. Since we're bumping major versions against at a x.0.0 release, perhaps it's worth considering if there are any additional breaking changes we want to make before a new major version release.
I'll bring up the elephant in the room again: keyword arguments, namely converting the existing option hashes in the API into keyword arguments.
My one sentence argument why: keyword arguments automatically check the validity of all keys passed and raise exceptions automatically for e.g. incorrect argument names, improving correctness. They also simplify passing defaults (no need to use the opts = { ... }.merge(options) pattern, and can therefore significantly reduce allocations (going from two Hash allocations to, depending on the underlying implementation, potentially zero).
I am happy to do the work on the conversion, although I'm curious if @ixti has warmed up to them at all over the years as he's voiced opposition in the past.
Another nice thing to integrate with another breaking change cycle is Socketry, particularly since if we're making breaking changes to the timeout API, there might be some additional ones to consider moving to a Socketry-based timeout system.
Thoughts? @ixti @zanker @janko-m
I think it was somewhat reasonable to not support keyword arguments in 2015. Given it's now 2018, and Ruby 2 was obsoleted for almost two years, I don't think there's a good reason to not support them.
It's fine for a HTTP library to be more conservative on Ruby support, but I don't think we should support Ruby versions that Ruby themselves don't support.
Oh did we bump the min? I missed that sorry! Then we absolutely should move to keyword arguments.
Another nice thing to integrate with another breaking change cycle is Socketry, particularly since if we're making breaking changes to the timeout API, there might be some additional ones to consider moving to a Socketry-based timeout system.
Yes, I would love to see https://github.com/httprb/http/pull/377 merged before 4.0, I think it's a good opportunity for that. I will try to help with porting some socket-related fixes from HTTP.rb to Socketry.
