hsunwenfang

Results 11 comments of hsunwenfang

> Looking at the HPA API the problem should exist for ContainerResource and Object metrics because in both scenario we don't differentiate based on the object that is targeted by...

[ASK] Hi @ingvagabund I'm working on TestLeaderElection and is refering your commit for TestTooManyRestarts https://github.com/kubernetes-sigs/descheduler/commit/ab467a5dd29925eb3fd794d2d93965f4a58281fc Where L57 of e2e_toomanyrestarts_test.go the "sigs.k8s.io/descheduler/pkg/framework/plugins/removepodshavingtoomanyrestarts" is imported While there is no corresponding folder for...

Hi @ingvagabund Thanks you for all the instruction I added a commit and comments, please help on commenting~ And I did the 'make test-e2e' locally It seems to be failed...

Hi @ingvagabund Thank you for the explanation, allow me to clarify further. So the goal here is to replace direct call of `RunDeschedulerStrategies()` with deployment. Q1 Should the namespace for...

Hi @ingvagabund Thanks for the help always During testing, my minikube node failed to pull **docker.io/library/descheduler** And My docker account seems not authorized as well `Trying to pull docker.io/library/descheduler:latest... Error:...

> > > sorryt, I can't split the PR into multiple commits; many of the changes were made together. > > > > > > It's a good exercise to...

Hi @ingvagabund I would like to contribute, thx!

Hi @ingvagabund I'm working on TestLeaderElection and is refering your commit https://github.com/kubernetes-sigs/descheduler/pull/1472/commits/ab467a5dd29925eb3fd794d2d93965f4a58281fc Where in L57 the "sigs.k8s.io/descheduler/pkg/framework/plugins/removepodshavingtoomanyrestarts" is imported While there is no corresponding folder for leaderelection Should "sigs.k8s.io/descheduler/pkg/framework/plugins/defaultevictor" be...

Hi @googs1025 Thanks for the instruction WIP PR raised and added detail to my ask there https://github.com/kubernetes-sigs/descheduler/pull/1497#issuecomment-2290503550

Thanks @IvanIsCoding for all the suggestion Please feel free to point out any further things~