encoding_c

encoding_c copied to clipboard

atouchet

The define ENCODING_RS_ENCODING is unusual way of wrapping

3

Noticed that this library does some tricks that are unidiomatic for C++. I'll post a minimal example. ```cpp // library.h #ifdef __cplusplus #define ENCODING_RS_ENCODING CppEncoding class CppEncoding { //no data...

dimztimz

With webrender we're using https://github.com/rlhunt/cbindgen/ instead of rusty-cheddar to generating bindings. I'd be interested in knowing if using cbindgen works for you and if not why.

jrmuizel

The FFI bindings in this library are missing null checks and panic handlers that would avoid undefined behavior. The documentation does warn users about conditions that will trigger undefined behavior,...

marco-vassena