Hironori Shiina
Hironori Shiina
Hi, Is this work still required? Regarding OpenShift, Butane is available for configuring kdump since OpenShift 4.8 as in [documentation](https://docs.openshift.com/container-platform/4.8/support/troubleshooting/troubleshooting-operating-system-issues.html#enabling-kdump-on-day-1). This doesn't look so complicated for those who want to...
Thank you for the comments. I will update the PR.
I'm afraid I got busy for other tasks after the last comment and have not been able to spend time on this work.
This fix looks to have been fixed by #[115331](https://github.com/kubernetes/kubernetes/pull/115331). Once all containers in a pod are stopped, the pod status is updated. https://github.com/kubernetes/kubernetes/blob/7c48c2bd72b9bf5c44d21d7338cc7bea77d0ad2a/pkg/kubelet/kubelet.go#L2095-L2100
There is a test case that tries to change a QoS class at resizing in e2e tests. Modifying this string might be helpful to verify this fix: https://github.com/kubernetes/kubernetes/blob/6e8e1f53b09328849f655d38eae9bacbbeb3445e/test/e2e/node/pod_resize.go#L1448
I reproduced a similar issue locally. I will investigate. /assign
I reproduced this issue as follows: 0. Enable the `InPlacePodVerticalScaling` feature gate. 1. Create a pod which has a container whose `resizePolicy` is `NotRequired` and a container whose `restartPolicy` is...
This issue happened as follows: 1. The first resize was requested. Then, kubelet started to resize both containers. 2. While the first resize was in progress, the second resize (rollback)...
**_Problem-1_** I guess the second resize for `c2` was skipped here: https://github.com/kubernetes/kubernetes/blob/f386b4cd4a879e8e7c4c255900a755bd0a61f8f0/pkg/kubelet/kuberuntime/kuberuntime_manager.go#L565 `apiContainerStatus` was based on the API pod status when the second resize was requested. When it was requested,...
**_Problem-2_** I guess the pod status degradation was similarly caused. The pod status was overwritten with the old status here: https://github.com/kubernetes/kubernetes/blob/790dfdbe386e4a115f41d38058c127d2dd0e6f44/pkg/kubelet/kubelet.go#L2863 `updatedPod` was created from an API pod which had...