Harshal Sheth

Results 177 comments of Harshal Sheth

@xxniuren you're right that this is a known bug. syu on the DataHub Slack is actually already working on a fix for this

@xxniuren are you still working on this?

@cuong-pham could you confirm that this is still an issue?

@cccs-Dustin I see that this PR is still in draft - are you waiting for a review? Also, we've made some simplifications to how stateful ingestion needs to be implemented....

@cccs-Dustin absolutely - just @ me here and I'll take another look at when you're ready

@szalai1 would any of your prometheus work be relevant here? I'm thinking we could reuse the `/metrics` endpoint as a healthcheck

@egemenberk some query cleaning logic is also getting adding in this PR https://github.com/datahub-project/datahub/pull/9838 - that one also removes parameter names and things to make SQL parsing work. Does it make...

@alexs-101 thanks for the PR! Before diving into the code, I wanted to make sure I understood the motivation behind each feature. Btw - it makes it a lot easier...

One other thing - it seems like the t-sql changes only make sense when `QUOTED_IDENTIFIER` is OFF (as per https://stackoverflow.com/questions/62917351/what-is-the-syntax-of-a-string-literal-in-t-sql) - so I'm not sure it makes sense to change...

@alexs-101 @egemenberk I agree those failures look unrelated, and I believe have been fixed on the master branch. I just synced this branch with master, and hopefully that unblocks CI