Harshal Sheth

Results 177 comments of Harshal Sheth

The formatting of the use case list is pretty ugly - not super readable, extra `*` characters, some headers are italics and others not

Yep - just updated it, and will merge it when CI is green.

We'll need to think about what to do with our README in a bit more detail.

@reata thanks for the amazing library! I wanted to chime in on the dependency piece. My main concern is around ease of installation, which is why item 1 seems pretty...

> Why would networkx installation be a problem? The issue isn't with networkx itself, but networkx depends on a number of libraries (e.g. scipy, matplotlib) which do have C bindings...

I took a peek at the sqllineage code that uses networkx, and agree that it's not worth ripping out. In that case, I think it makes sense to leave the...

Update here: I'm working on loosening our SQLAlchemy dependency in https://github.com/datahub-project/datahub/pull/6204.

Additional context here: non utf-8 characters seems to work on the python side + on the frontend. I only tested the description field though, so @fr-judson let me know if...

@sgomezvillamor I'm working on https://github.com/datahub-project/datahub/pull/6083, which should accomplish the end goal as this PR while maintaining backwards compat a bit better.

Added to our fork instead: https://github.com/acryldata/PyHive