hseg

Weirdly enough, the tests now pass. I've changed nothing in the past month, only rebasing the PR onto master a couple weeks back. I also did end up generating the...

@xnetcat do you want me to rebase?

Weird, but at least confirms situation was too good to be true. Just to rule out a confounding variable, what's your `yt-dlp`? I'm on `2024.10.07.r12, revision cba7868`

... :facepalm: the script I was using to run was only checking `tests/test_matching.py`. That's what I get for returning to the project a month later, sorry for wasting your time....

On my end, with `--block-network -m 'not test_config' -m 'not novcr'` (I'm skipping `test_config` due to #2058), am getting in chroot: ``` FAILED tests/console/test_entry_point.py::test_download_song - SystemExit: 1 FAILED tests/console/test_entry_point.py::test_preload_song -...

OK, the `test_metadata` failures seem to be because `ffmpeg` isn't seeing the `vcr` -- it tries querying `rr4---sn-nhpax-ua8d.googlevideo.com`, which gives 403 rn (presumably this is a dynamically-generated URL)

oops, forgot to squash first

Of the errors we had: - Solved `tests/utils/test_ffmpeg.py::test_convert` and `tests/utils/test_metadata.py::test_embed_metadata` by manually downloading the files (so that their download would be covered by vcrpy). - At a guess (am currently...

BTW, I've noticed the testsuites take a long while to run on CI -- ~5h in the latest run. Any idea what's going on with that?

Hrm. Weirdly enough, on chroot: ``` FAILED tests/console/test_entry_point.py::test_download_song - assert 'Downlo... FAILED tests/test_init.py::test_download - AssertionError: assert None not in... FAILED tests/utils/test_ffmpeg.py::test_convert - yt_dlp.utils.DownloadError:... FAILED tests/utils/test_metadata.py::test_embed_metadata[mp3] - yt_dlp.networ... FAILED tests/utils/test_metadata.py::test_embed_metadata[flac] -...