hseg

Results 225 comments of hseg

Had forgotten to subscribe to this PR, finally saw it got merged. Thanks for pushing it over the finish line, am updating the AUR package to pull from master again...

Successfully built with passing testsuite using the branch `ghc-9.6` (currently at 4513c39d90b05f7f1a8f208d486df84ca3b408f4) with a bog-standard `stack build && stack test`. Forced `ghc-9.6.5` to get access to the LD patch from...

In trying to rebase this onto `v0.1.30.0`, I've noticed that you checked in `.orig` files. Was this intended?

OK, I finally finished rebasing. I pushed a branch in https://github.com/hseg/ghcup-hs/tree/rebased-ghc-9.6, it builds with all tests passing against `lts-22.33`. I've made some guesses as to how the freezefiles needed to...

btw, note my comment in https://github.com/haskell/ghcup-hs/pull/1123#issuecomment-2341428651 -- I think there may be some stale references in the docs

Attempting to ignore the broken tests, I see the following are also not vcr'd: - `tests/test_init.py::test_get_urls` - `tests/utils/test_m3u.py::test_create_m3u_content` - `tests/utils/test_m3u.py::test_create_m3u_file` - `tests/utils/test_search.py::test_parse_query` Besides those, I'm getting `vcr.errors.CannotOverwriteExistingCassetteException` on tests I...

In view of the above, I've added `vcrpy` invocations to the listed calls that are missing them. I've also regenerated the cassettes that were causing errors. On my system, this...

One cassette down, two to go. Though for some reason I've picked up a test failure in `tests/utils/test_ffmpeg.py::test_convert` on my system and flakily have picked up another in `tests/utils/test_metadata.py::test_embed_metadata` in...

Turns out `tests/utils/test_ffmpeg.py::test_download_ffmpeg` makes network requests as well. The cassette it generates is 110M, which is larger than Github's default maximal file size. I've commented it out for now to...