Hiroshi SHIBATA

Results 260 comments of Hiroshi SHIBATA

No, It accepts with https://github.com/rubygems/rubygems/blob/master/lib/rubygems/s3_uri_signer.rb#L108.

@luke-gru Can you keep the current indent style? We can view only code changes with https://github.com/flori/json/pull/512/files?w=1. But style changes may causes code-conflict when I backport this to ruby/ruby.

> So for that function it's not just a style change. I know that. I say `parser.rl` and `parser.h`. I hope you make your change is only https://github.com/flori/json/pull/512/files?w=1, not https://github.com/flori/json/pull/512/files.

I accept this proposal. But I'm not familiar with C internals. I requested additional review for @nobu

@mintuhouse see https://bugs.ruby-lang.org/issues/20085#note-12

@dorianmarie "Status" field is only for master branch, not backport status. You should look "Backport" fields.

GitHub is not discussion place for release engineering. Please use https://bugs.ruby-lang.org/issues/20085

Sorry to late response. I'll look tomorrow.

I confirmed this change to add `.so` files into `spec.files` and remove `lib/` prefix to .rb files for default gems. But I have some concerns. Sorry after my approval. I...