Hamada S. Badr

Results 69 comments of Hamada S. Badr

@jeffreypullin Agreed. I've picked this in https://github.com/stan-dev/rstan/pull/887 at https://github.com/stan-dev/rstan/pull/887/commits/23a7869bf141abd10d575b9ce4ca8b1a6681ff62.

> @hsbadr I'm happy for this to be picked into #887 but given how big #887 already is it might just be easier for @bgoodri to review and merge separately....

> Following the conversation on a [stanc3 pr](https://github.com/stan-dev/stanc3/pull/865#issuecomment-833650029) this modifies `csr_times_matrix_vector2` to have the same signature as the new stanc3 generated signature. It also just uses `csr_matrix_times_vector` since in the...

> Yeah it looks like the failure is something about the USELTO field in the description. I think the github action needs updated to a newer version of R It's...

@jgabry Since it doesn't fail locally, could you try to clear the R package cache by changing the number in the following lines: https://github.com/stan-dev/rstanarm/blob/ef08f58b1caeecff1a96e1e595f6741798ebbe5f/.github/workflows/R-CMD-check.yaml#L60-L61 You may try to replace `-1-`...

> Thanks. I just changed the 1s to 2s in [a6a8e6b](https://github.com/stan-dev/rstanarm/commit/a6a8e6b27f9666e97ccd2d4887a84c418dbd458f) (let me know if I misunderstood your suggestion). Let's see what happens. Thanks! That's exactly it. If it fails...

@jgabry There's 2 test failures, in `test_pp_check.R`. That means the build is successful, but the tests aren't. ```r Error: Running examples in ‘rstanarm-Ex.R’ failed Error: Error in eval(predvars, data, env)...

@jgabry Here's the raw logs for the failed tests: ```r ══ Failed tests ════════════════════════════════════════════════════════════════ ── Error (test_pp_check.R:56:5): pp_check.stanreg creates ggplot object ──────── ##[error]Error: Plotting function not supported. (If the plotting...

> I just fixed the `pp_check` test on master Thank you for the quick fix! > So if this PR passes everything except for the `logBili` error we can consider...

> Nvm what I said thank ypu v much @jgabry and @hsbadr As expected, this change isn't backward compatible: ```r ##[error]Error: package or namespace load failed for ‘rstanarm’ in dyn.load(file,...