rstan icon indicating copy to clipboard operation
rstan copied to clipboard

Remove rstan3 directory

Open jeffreypullin opened this issue 4 years ago • 3 comments

Summary:

Remove the (obsolete?) rstan3 directory following up on #898

Intended Effect:

Simplification of the structure of the repository

How to Verify:

These changes should be non-functional.

Reviewer Suggestions:

Copyright and Licensing

Please list the copyright holder for the work you are submitting (this will be you or your assignee, such as a university or company):

Jeffrey Pullin

By submitting this pull request, the copyright holder is agreeing to license the submitted work under the following licenses:

  • Code: GPLv3 (http://opensource.org/licenses/GPL-3.0)
  • Documentation: CC-BY 4.0 (https://creativecommons.org/licenses/by/4.0/)

jeffreypullin avatar Jan 29 '21 01:01 jeffreypullin

@jeffreypullin Agreed. I've picked this in https://github.com/stan-dev/rstan/pull/887 at https://github.com/stan-dev/rstan/pull/887/commits/23a7869bf141abd10d575b9ce4ca8b1a6681ff62.

hsbadr avatar Feb 04 '21 01:02 hsbadr

@hsbadr I'm happy for this to be picked into #887 but given how big #887 already is it might just be easier for @bgoodri to review and merge separately.

jeffreypullin avatar Feb 04 '21 04:02 jeffreypullin

@hsbadr I'm happy for this to be picked into #887 but given how big #887 already is it might just be easier for @bgoodri to review and merge separately.

Yes. After this gets merged, it'll have to be applied to #887 anyway to resolve merging conflicts. Hope both will get merged & we start from there.

hsbadr avatar Feb 04 '21 04:02 hsbadr