Stevie Hryciw
Stevie Hryciw
> I wonder how well-received it would be for method calls to be `a->b()`. Keeping in mind, if `b` were a namespaced function and `c` were a function pointer field,...
Definitely a must, but there are some considerations. Knowing how compatibility breaks so much between versions, it would be nice to have a few LOVE versions available, along with the...
Just some thoughts over coffee ☕️ - Should safe recursion be allowed at comptime? I suppose this would depend on: 1. a comptime allocator (#1291), but not out of necessity....
Thanks @ifreund, great suggestions. Agreed about guarding against future churn. My original thinking was to avoid duplicating the code from `isValidId()`, but now I think it makes more sense to...
The suggestion worked like a charm. Now it covers everything, doesn't allocate, and is much cleaner. Last concern: I duplicated most of the code from `parseAppend` into `parseWrite`. It's not...
CI caught a missed case: identifiers that are escaped keywords. Added a stub fix that currently fails but I can come back to look closer shortly. (Apologies for the noise)
As mentioned by @InKryption [in a comment](https://github.com/zigtools/zls/pull/724#issuecomment-1294516558): > fields with the name `type` can be written without `@""` syntax This reminds me of some cases I hadn't considered: ```zig const...
> type isn't actually a keyword but rather an identifier in the global scope. Your code should actually already handle that example properly as std.zig.isValidId() returns true for type. You...
_(Pardon my edits if you are reading this after an email alert)_ Because of the cases I previously overlooked, I thought I'd write out my assumptions below to make sure...
Snap, somehow my eyes glazed over this comment: https://github.com/ziglang/zig/blob/b40fc70188fd097e9e05b5c18b635b67b718380e/lib/std/zig/render.zig#L187-L188 To keep things simple, I'd be ok worrying about that till after this is PR is done since `renderSpace()` has no...