Harshad
Harshad
If you're not married to using `Pronto`, may I suggest using `SQLImplementation`? It is definitely faster than the former. ``` from oaklib.resource import OntologyResource from oaklib.implementations.sqldb.sql_implementation import SqlImplementation resource =...
Issue arises from another [project](https://github.com/berkeleybop/bbop-ner-tasks/issues/19#issuecomment-970770214)
In the code, the first `if` condition that is satisfied: ``` if stanza1 is None: stanza1 = Stanza(id=stanza2.id, type=stanza2.type) if stanza2.type == "Term": yield kgcl.ClassCreation(id=_id(), about_node=stanza2.id) elif stanza2.type == "Typedef":...
Thoughts @cmungall I'm thinking of : ``` if stanza1 is None: stanza1 = Stanza(id=stanza2.id, type=stanza2.type) if stanza2.type == "Term": # yield kgcl.ClassCreation(id=_id(), about_node=stanza2.id) pass elif stanza2.type == "Typedef": yield kgcl.NodeCreation(id=_id(),...
The above solution seems to break tests so I'm going to wait on this one and close the PR linked above.
Hey @anitacaron , I'm on parental leave until Monday next week. Will look into this then. Sorry for the delay
Hey @anitacaron , the issue should be resolved with oaklib v0.6.10. Please confirm so I can close this issue.
Sounds good, please tag me in the issue !
Solution to this: In basic_ontology_interface.py, [this line](https://github.com/INCATools/ontology-access-kit/blob/15bf85cefc2fe8541b38aabfcf7c65eb46bc1231/src/oaklib/interfaces/basic_ontology_interface.py#L205) needs to be ``` self._converter = curies.Converter.from_prefix_map(self.prefix_map(), strict=False) ``` This asks the `curies` package to be less strict and allow duplicate prefixes. As...
[Joe wrote](https://github.com/INCATools/ontology-access-kit/pull/511#pullrequestreview-1371937790): > @hrshdhgd Ever seen this before? If not, I can look into a bit more before raising to Chris or someone else. > > * [ ] tests/test_converters/test_obo_graph_to_fhir.py:282:1:...