Hristo Georgiev

Results 21 comments of Hristo Georgiev

Hi @nathanshammah, Could this issue perhaps be broken into sub-tasks in some way, perhaps, in order to enable work starting on it a bit more feasible? Also, I can see...

Hi @apoorvpandey0, I'd suggest checking if your Python version (the one corresponding to your `pip` commands you've referenced) is supported, as well as your OS version. This could be, for...

I've fixed the linting changes locally (and substantially reduced the computational size of the test), but the `test_pandas` still hangs. I've played around a bit, but haven't been able to...

Once the maintainers confirm approval of the proposed changes, I'll be happy to update the `.rst` docs accordingly, to document the updated API, in a separate commit (as part of...

From the latest CI runs (e.g., [this](https://dev.azure.com/dask-dev/dask/_build/results?buildId=2011&view=logs&j=ec4c5d99-1a39-52ae-ac68-aabdfb55b8a0&t=86aed08f-9978-51ce-ee60-f0db228672cd&l=17) job). ```bash black, version 19.10b0 would reformat /home/vsts/work/1/s/tests/test_pca.py Oh no! 💥 💔 💥 1 file would be reformatted, 99 files would be left...

Hi @TomAugspurger - I'm writing to check if you've had a chance to look into the further changes that I pushed since [your review](https://github.com/dask/dask-ml/pull/808#pullrequestreview-619138162), and whether you'd like any additional...

> It'll be a week or so before I can take a look. Thanks for your patience! It's all good - just wanted to check if this is still on...

> I had some time to go through and review today. Overall, I'm in favor of the change and I can understand how it could be a nice optimization for...

@jsignell, I've just discovered your https://github.com/dask/dask/pull/7370 (I can see that the `isort` version there is `5.7.0`, and also that the PR is in a draft state). Could you, please, have...

> My main suggestion is that in dask/dask, there is a github action that runs pre-commit. Thanks for checking this out, @jsignell! Apologies - I'm not very familiar with GitHub...