Hasan Ramezani

Results 377 comments of Hasan Ramezani

Thanks @sum-rock for the patch :+1: I haven't checked it completely, but I think migration is missed and you need to add a changelog as well. @alieh-rymasheuski @Linkid Could you...

> @hramezani @Linkid Thanks for the review. I added a migration and updated the changelog. Sorry about the missing migration! I'm not experienced in contributing to Django packages with migrations....

> @hramezani I noticed in the migration file that you suggested it changed the `null=True` to `blank=True` should this be changed on the model too? I can understand if you'd...

@alieh-rymasheuski > Are there any users of django-auditlog who don't have native support for JSON field in their DBMS? As all official DB backends in Django support `JSONField` I think...

@sum-rock @alieh-rymasheuski I've tested the change on `SQLite3` and `PostgreSQL`. here are the results: On `PostgreSQL`, with 320000 records in `LogEntry`. The migration took 5 second: Here is the `sqlmigrate`...

Thanks @sum-rock The patch seems good to me now. I will merge it when we are going to prepare version 2 (I don't know when exactly)

> Thanks everyone for the collaboration! I felt like this was a natural progression to the code and fits within the vision for your project. I'm glad you guys agree!...

Thanks @sum-rock for the PR :+1: I am still not sure about the idea of the feature. I will back to the PR later. Unfortunately, I don't have time to...

Thanks @sum-rock for the update. I will take a look whenever I have time.

To me, the change has two parts 1. Adding a JSON field to store the JSON repr of the object. (sounds good) 2. The `HistoricalStateLookupManagerMixin` class, is about how we...