John Howard comments

Results 1679 comments of


                                            John Howard

ambient: fix nil pointer when pod cache is stale

> > We are looping outside of GetPodIfAmbient for the pod to show up, but if it fails we panic. We want to instead get an error. > > I...

High CPU on istiod control plane 1.19.8

Also I would upgrade. Istio 1.19 is EOL and we have performance improvements in every release, including major ones in 1.21.

Expose PadForwardPayloadHeader in JWTRule

Can you explain why we need this? IIUC this means we are going to take a encoded token that we said we would **forward** and modify it? Why?

sds: simplify implementation to reduce dependencies

The syncz is https://github.com/istio/istio/blob/903ba1a06b4bacd8448cd7da10630b065cb4b8d1/pkg/istio-agent/xds_proxy.go#L787. its not implementing syncz itself, its a proxy server to Istiod

Use label istio.io/dataplane-mode=disabled for pod-level ambient opt-out

https://preliminary.istio.io/latest/docs/ambient/architecture/#ambient-labels

Incompletely support of traffic.sidecar.istio.io/excludeOutboundIPRanges while upgrading istio from version 1.15.2 to 1.20

It's not changed. It was alpha and continues to be alpha

Incompletely support of traffic.sidecar.istio.io/excludeOutboundIPRanges while upgrading istio from version 1.15.2 to 1.20

It is an alpha feature: https://istio.io/latest/docs/releases/feature-stages/

Incompletely support of traffic.sidecar.istio.io/excludeOutboundIPRanges while upgrading istio from version 1.15.2 to 1.20

Nothing, the message is logged for any alpha features.

enable deferred cluster creation

I jsut have https://github.com/istio/istio/issues/49868#issuecomment-1994591948

HTTP/L7 metrics for TLS-terminated downstream requests in a Gateway

Can you share a config dump (`istioctl pc all PODNAME`)? Istio knows when its HTTPS and does HTTP metrics, so this means either: * Its not actually doing what you...