istio
sds: simplify implementation to reduce dependencies
Issue: #50134
This brings down the binary size for pilot-agent to under 30MB.
CC @dpasiukevich
I don't quite understand where /debug/syncz is implemented in the agent - I thought I dropped discovery server debug handlers.
The syncz is https://github.com/istio/istio/blob/903ba1a06b4bacd8448cd7da10630b065cb4b8d1/pkg/istio-agent/xds_proxy.go#L787. its not implementing syncz itself, its a proxy server to Istiod
@howardjohn OK, that will pull all the Envoy protos used in listener, cluster, route, and extensions -- something we don't want to do just for debug endpoint. I removed that test since it doesn't seem to be critical -- you can decode Protos out of band.
@syw14 I think this change is fine because istioctl x proxy-status --xds-via-agents is still passing. On the wire, agent is sending the content base64 encoded Any, which istioctl is capable of decoding.
@igsong confirmed this change doesn't break gcloud debug command. Thank you @igsong .