Martin Hořeňovský

Results 103 comments of Martin Hořeňovský

This will need some fixes to the path normalization code in approval tests.

@timblechmann Approval tests run the `SelfTest` binary and compare the output to a known good one. The implementation is in `tools/scripts/approvalTests.py`, and the problematic part is in `normalizePath` function, which...

Can you provide an example of when this warning triggers?

I tried to quickly [reproduce this on godbolt](https://godbolt.org/z/rEW5da7Pf), but can't. Given that this PR would silence `-Wcomma` for the entire test case code, including user's code, I do not want...

There is now a migration guide, and the readme has been updated to point to the old release branch and the migration guide.

I am willing to merge a PR with reasonable workaround, but otherwise my advice is to use a better compiler.

Hi, sorry for taking so long. Your PR happens to be in the goldilocks zone of not being good enough to approve outright, not being bad enough to reject and...

2) or 3), depending on how annoying the signature would be. I don't think the console and compact reporters should have a shared base class.