Catch2 icon indicating copy to clipboard operation
Catch2 copied to clipboard

Just some documentation.

Open nandanvasudevan opened this issue 1 year ago • 3 comments

Description

Adding includes to the documentation and a basic test case with a lambda.

GitHub Issues

#2519 - Added headers for parts of Catch2 that I am aware of. #2513 - Basic test case with a lambda.

nandanvasudevan avatar Oct 05 '22 03:10 nandanvasudevan

Codecov Report

Merging #2541 (ea37a0c) into devel (77f7c01) will increase coverage by 0.01%. The diff coverage is n/a.

@@            Coverage Diff             @@
##            devel    #2541      +/-   ##
==========================================
+ Coverage   91.57%   91.58%   +0.01%     
==========================================
  Files         183      183              
  Lines        7564     7564              
==========================================
+ Hits         6926     6927       +1     
+ Misses        638      637       -1     

codecov[bot] avatar Oct 05 '22 05:10 codecov[bot]

Is there anything I should do here?

nandanvasudevan avatar Oct 29 '22 15:10 nandanvasudevan

Hi, sorry for taking so long. Your PR happens to be in the goldilocks zone of not being good enough to approve outright, not being bad enough to reject and the subject matter not being interesting enough to prioritize (small doc update versus SKIP or adding support for comparisons including std::*_ordering).

Anyway, I think the PR should be split into two, so they can progress separately. I recommend moving the lambda part into its own PR (I'll leave some notes on that separately), and leaving the include docs in this one.

horenmar avatar Nov 05 '22 13:11 horenmar