Bart Dubbeldam

Results 15 comments of Bart Dubbeldam

> Beyond the mechanics of the implementation I'm also interested in how this interacts with revocation. This is one of the aspects of raw public keys that I think deserves...

> > there is a decode error when running the example against openssl with `--verify 1`. However, this only happens when using tls1.2 not tls1.3. Reading the logs it seems...

Thanks for the feedback and all the work so far. Except for the comments on `rpk_example.rs`, we've incorporated all the feedback. In case I wasn't sure whether our approach is...

@cpu I think so too! Thanks for this round of feedback. Most of it is already processed, and beginning next week I'll finish it and push everything.

We've incorporated all the feedback and finished the todo's. Thanks for all the great help and feedback so far. Hopefully we can get this merged soon ;) Two remarks about...

Thanks for all the thorough feedback and consistent input! I just processed the last outstanding comments (sorry that it took a bit longer), and I think it's ready to merge!

As discussed with @cruessler during a call, we decided to make the API more robust and less error-prone. We've removed the distinction between `BlameRanges:OneBasedInclusive` and `BlameRanges:ZeroBasedExclusive`. Instead, we now only...

Bit surprised about the CI-error. Any hint for that?

Thanks for the review @cruessler. I've implemented almost all your changes. I feel that the difference between `one_based_inclusive_ranges` and `zero_based_exclusive` leaves some room for error and confusion. What do you...

@cruessler got a bit distracted indeed, my bad. Will update the PR with the changes this week. Main thing outstanding is not erroring, but turning `WholeFile` into a `PartialFile` as...