Holly Cummins

Results 224 comments of Holly Cummins

Merging of this is paused pending adding the M1 runner, which is paused pending https://github.com/quarkusio/quarkus-github-bot/issues/256.

I've added an extra set of rules which leverage https://github.com/quarkusio/quarkus-github-bot/issues/256 to control what PRs are allowed to run on the runners. This helps secure both the new M1 runner and...

I wasn't planning to enable the M1 runner until the repo workflows were locked down and bot configuration was pushed. To allow the timing of the two things to be...

See https://github.com/quarkusio/quarkus/pull/27899 for the bot changes, which should be merged first.

Another nearly clear run on M1: just this failure, which seems to me to be a brittle test. The output is the same as the expected, except for the order...

(I'll re-run to confirm the `smallrye-config` failure is intermittent/unrelated-to-m1, and to incorporate the latest changes.)

Same smallrye config failure on the next run, so I have disabled and raised https://github.com/quarkusio/quarkus/issues/28057.

I've also spotted some differences in testing; for example, the workshop uses `@Mock` for the proxies, and the main repo has a different test mechanism.

I've made some updates to the changeset, following our discussion above. I think it's ready for re-review, @aloubyansky . ## What does this changeset do? It adds additional generated information...

(I've looked at those test failures and I don't think they can be related to this change.)