Steve Hollasch
Steve Hollasch
Resolved in #1053
I go back and forth with formalizing our rendering setup through a `camera` class (and possibly a `renderer` class). In the end, I keep abandoning this as it feels like...
Actually, it should be public, and we should remove the accessors. There's no reason to guard these members, as it's not possible to create an inconsistent state, so the encapsulation...
Note that in general we could do an encapsulation pass, as this is something we have scattered among our various classes. The way the code is structured, many of these...
I added the additional `public` specifier to mark the beginning of member variables, preserving original access class. If we decided in the future to convert to greater encapsulation, we could...
More and more (and this is a personal opinion), I chafe at the automatic getter-setter method for private member variables, when they are uniformly implemented in trivial fashion. It feels...
Just found out that we need the `ray() {}` constructor, because we have uninitialized declarations (later assigned), and the compiler doesn't automatically provide the default constructor. You'd need to explicitly...
Also, out of curiosity I tried just making all member variables `const`, but that leaves you with the inability to assign new values to `ray` variables. Guess that's why you...
? The only thing `struct` does is default access to public. Flipping to `class` doesn't change any of the above.
Well, I look at that and see a `struct`, but I am feeling very not strong about this one. Win win! The only change to the above is that we...