Michael Hoisie
Michael Hoisie
Hi Matthew, It was done purely based on usage patterns. I looked at my code and realized that every single time Render or RenderFile was called, the return value was...
Furthermore, I'm a big subscriber of the DRY principle (don't repeat yourself), which is at odds with the way Go does error checking.
I suppose I could add MustRender and MustRenderFile which panics instead of returning the error. However in a production environment that would bring down the server instead of displaying the...
I'd accept a pull request that changes it back to returning an error. Is there one open?
I think the current tests provide fairly good coverage, but I'd gladly accept more test cases.
Yes but are there tests that are in a format we can use? Some Ruby tests may specifically test mustache with Ruby class inheritance, for instance, and those are hard...
That looks really, really cool. Looking forward to seeing progress on this. Are there features this spec tests that mustache.go doesn't have yet?
It's very hard for me to see the actual diff because of all the whitespace changes. Can you just run 'make format', and send a new pull request? `make format`...
I must admit recursive partials do seem a bit strange to me, but I can imagine a use case.
Nice example @thoughtmonster ! This should definitely be supported. The parsing is recursive, so there might be a quick solution if can some how mark partials as already visited.