Michael Hordijk
Michael Hordijk
Thanks for the feedback! Obviously, this was a quick change that solved my immediate need. However, I agree that it could certainly be made more robust and feature complete. >OTOH...
The crux of it is here: https://github.com/pytorch/pytorch/blob/5acc27c00a131c3e8ce4dad6e06222bb40f30dc7/c10/util/variant.h#L281 clang supports a `__type_pack_element` builtin. So the code will be generated using that. However, some downstream Nvidia tools, not so much. I think...
I've got a handful of bug fixes, features, and unit tests that we added to build_tar.py. I'd rather consolidate down onto rules_pkg and do any work on that implementation so...
A [quantity point](https://aurora-opensource.github.io/au/main/discussion/concepts/quantity_point/) represents a measurement from an origin. In this case, 0 K. In affine space, you can _subtract_ two points to get a vector (which would be a...
I agree. When coming into a units library, the distinction is not something we're used to. Temperature happens to be a great example. If I give you a value and...
Note that our [style guide](https://google.github.io/styleguide/cppguide.html#Defining_Functions_in_Header_Files) has: > ... within a namespace that includes the word `internal`... Abseil looks like it uses this convention as well, further splitting up their internal...
Are we talking about the APIs that have [this documentation in the header file](https://github.com/google/googletest/blob/6ec14dfd8c409d05fba94e18e3a02df35b874353/googletest/include/gtest/internal/gtest-port.h#L189)? ```c++ // Internal utilities // ------------------ // // The following macros and utilities are for Google...
Seems like this may be a dup of #5564?
While most C compilers support it as an extension, the `= {}` syntax doesn't become valid C until C23. We have two things we could potentially do: 1. Update our...