hochoy

Results 12 comments of hochoy

Thank you, did not expect such a prompt reply. I'll take it out of draft. - done ✅ Regarding your first issue comment, I had suspected that might have been...

https://docs.npmjs.com/cli/v9/configuring-npm/package-json ![Screen Shot 2023-07-18 at 10 14 48 AM](https://github.com/npm/cli/assets/12564636/5ac5a304-3cd5-4b14-97ff-bc888a0777cb)

same issue here, ggplotly resets the "space=free" argument

Implementation for this will likely follow similar approach as the instructions in this link. https://www.contentful.com/developers/docs/tutorials/general/embargoed-assets-getting-started/#rewriting-a-single-asset-url ![Screen Shot 2023-05-19 at 3 45 17 PM](https://github.com/contentful/contentful-cli/assets/12564636/b4f348a9-78b8-48c1-bfca-4776012c3a81) Or perhaps there's a bug.

@ddelgrosso1 , I tried running `samples-test` and `system-test` but based on the logs, it appears those require an active project in order to do an e2e/live test against real GCP...

Also, I would like to add a test to check that the files are truly downloaded into the `local machine` or `memory`. Would you recommend I give that a shot?...

Hey @danielbankhead @ddelgrosso1 , just wanted to provide a heads up that I'll be revisiting this in about 1-2 months due to project priorities. Thank you for all the feedback...

I was looking for the unit-test file for `./lib/core/connect.js`, which exports `buildConnector`, but can't seem to find the test file. Can you point me there?

As for integration and e2e tests, it is a little difficult to simulate this edge case. This is the environment in which this can happen: 1. The server is deployed...

I have tested this `optional chaining` locally on 6.20.0, 6.20.1 and it fixes the `TypeError` when `socket` is `undefined`. `6.19.8` does not have this issue, so I looked through the...