viv icon indicating copy to clipboard operation
viv copied to clipboard
verified publisher icon hms-dbmi

fix(layers): Pass through `opts.renderPass` to @luma.gl `model.draw`

Open manzt opened this issue 10 months ago • 3 comments

Fixes #854, which I believe was introduced in #805.

Fixes #

Background

Change List

Checklist

  • [ ] Update JSdoc types if there is any API change.
  • [ ] Make sure Avivator works as expected with your change.

manzt avatar Jan 28 '25 18:01 manzt

I am ok with this but I don't really understand how it arose all of a sudden.

ilan-gold avatar Jan 29 '25 17:01 ilan-gold

(which is confusing)

ilan-gold avatar Jan 29 '25 17:01 ilan-gold

I was able to reproduce the error by upgrading deckgl/luma to v9.1 on main. So yes, the error was from upgrading to a server range we don't support.

I guess the question is should we make this change and bump the semver range?

manzt avatar Jan 29 '25 20:01 manzt