Hamed Montazeri
Hamed Montazeri
That's awesome have a nice idea how to do that!
@teolemon I subscribed to the mailing list. However, can we speak about your api? Is there any documentation?
@annalisetarhan thanks for the PR. Could you please check the CI? https://travis-ci.org/github/hmontazeri/is-vegan/jobs/699300029 Seems like the JSON files have syntax errors. Somewhere in nonvegan.json.
@annalisetarhan unfortunately it's still failing. The tests don't pass anymore, probably because the ingredients in the test cases aren't correct anymore. Could you please have look at those? https://travis-ci.org/github/hmontazeri/is-vegan/jobs/700027479#L260 https://travis-ci.org/github/hmontazeri/is-vegan/jobs/700027479#L263
@annalisetarhan looks good. Going to merge it the coming days. Thanks for your effort!
@lucasrodes That’s a very good question. I guess the easiest way would be having a maintainer for each language?
Good point! will be added. Thx!
I understand what you mean, a wildcard search is not the answer as well... It could match parts which could make it worse than matching an exact string...
@fluxsauce how about adding a regex search for obvious meat / fish species?