Hamish Moffatt comments

Results 214 comments of


                                            Hamish Moffatt

Improvements and sf3 import

@davy7125 the code on the your branch doesn't compile. sfconvert.cpp is missing semicolons at lines 121-122, and sf.smallSf does not exist at line 131.

Improvements and sf3 import

Also, I converted an SF3 of mine back to SF2 and it sounds terrible, nothing like the original SF2 (or SF3).

work with std::range::subrange

It looks like there is std::ranges::range_value_t for this.. I don't know if this fits in with your ValueTypeHelper though. https://stackoverflow.com/questions/74496713/how-to-get-the-type-of-the-values-in-a-c20-stdranges-range

work with std::range::subrange

Looks good! I tried a few things with QVector and std::vector and it worked as expected, on g++/clang++/MSVC. I tried working on a subrange of std::map and didn't have much...

check for subuid/subgid fails with 'is not a directory' error

I think it should use `lineinfile` with check_mode: yes and so on, as in https://www.middlewareinventory.com/blog/ansible-search-string-file-check-if-string-exists/

Login fails when using the docker image

You can run adhoc commands in the running container with `sudo docker exec -it semaphore_semaphore_1 /bin/sh` eg ``` $ semaphore user list --config /etc/semaphore/config.json Loading config Validating config admin ```

Login fails when using the docker image

I am using the example `docker-compose.yml` (https://docs.ansible-semaphore.com/administration-guide/installation#docker) and haven't added any other users, and I see `admin` listed. I don't know why it wouldn't work for you.